dimfalk / netatmo.weather

R wrapper for Netatmo Weather API
GNU General Public License v3.0
3 stars 0 forks source link

`get_period()`: change timezone information to `"UTC"` #63

Closed dimfalk closed 5 months ago

dimfalk commented 5 months ago

c.f. #62

Ticket #3150594, waiting for a reply

dimfalk commented 5 months ago

c.f. README:

Query:

library(netatmo.weather)
#> 0.5.11

# hourly data
p2 <- get_period(res = 60)
as.POSIXct(p2, origin = "1970-01-01")
#> [1] "2024-02-21 06:00:00 CET"  "2024-04-03 23:00:00 CEST"

Response:

# inspect index range
zoo::index(xts) |> range()
#> [1] "2024-02-21 06:00:00 CET"  "2024-04-03 21:00:00 CEST"

--> UTC or cut-off values?

dimfalk commented 5 months ago

Response from Netatmo support:

As you said Unix time is always based on UTC. I don't know why we talk about "local" Unix time as it's not an existing notion as far as I know (it's probably something to fix in the documentation to avoid confusion). So, there is nothing specific on our side in the way we display or ask for timestamps.

Concerning the time_server it's the same : it corresponds to when the request was handled by the server and based on UTC timezone. So you just have on your side to use it according to your local timezone.

dimfalk commented 5 months ago

c.f. README:

Query:

library(netatmo.weather)
#> 0.5.13

# hourly data
p2 <- get_period(res = 60)
as.POSIXct(p2, origin = "1970-01-01", tz = "UTC")
#> [1] "2024-02-22 06:00:00 UTC" "2024-04-04 22:00:00 UTC"

Response:

# inspect index range
zoo::index(xts) |> range()
#> [1] "2024-02-22 06:00:00 UTC" "2024-04-04 20:00:00 UTC"