search

dimforge / alga

Abstract algebra for Rust.
194 stars 39 forks source link

impl Add for Id<Additive> instead of Id #38

Closed ExpHP closed 6 years ago

ExpHP commented 6 years ago

It seems suspicious to me that Zero and Add would be implemented for Id<Multiplicative>. Is this what was intended?

(note: this is a breaking change)

jswrenn commented 6 years ago

This seems suspicious to me, too. @sebcrozet?

sebcrozet commented 6 years ago

Yes, this is definitely wrong. Thanks for correcting this!