dimforge / nalgebra

Linear algebra library for Rust.
https://nalgebra.org
Apache License 2.0
4.04k stars 485 forks source link

Do not explicitly set rkyv pointer size #1449

Open arbor-arthur opened 1 month ago

arbor-arthur commented 1 month ago

Cargo.toml currently sets rkyv-serialize-no-std = ["rkyv/size_32"] which prevents using rkyv with any other pointer size. It is best practice for libraries to not set the pointer size and allow binaries to choose the pointer size themselves. For myself, I patched this to rkyv-serialize-no-std = ["rkyv"], although I imagine that testing might require it to still be set in some circumstances?