Provide bounding volume methods without an isometry parameter

dimforge / ncollide

2 and 3-dimensional collision detection library in Rust.

https://ncollide.org

Apache License 2.0

921 stars 105 forks source link

Provide bounding volume methods without an isometry parameter #286

Closed ghost closed 5 years ago

ghost commented 5 years ago

Resolves #283. As discussed earlier, we should do the same thing for the support map trait in the future.

ghost commented 5 years ago

Good catch! It slipped my mind that these traits can also be implemented by users of this crate. I've pushed changes to resolve your comments.

sebcrozet commented 5 years ago

Thanks @aleksijuvani! I've added one more suggestion because I missed one detail on the default Shape::bounding_sphere implementation. It turns out the existing implementation was wrong.

ghost commented 5 years ago

Should be all good now!

sebcrozet commented 5 years ago

Great, thanks!