Use `slice::iter` instead of `into_iter` to avoid future breakage

dimforge / ncollide

2 and 3-dimensional collision detection library in Rust.

https://ncollide.org

Apache License 2.0

921 stars 105 forks source link

Use `slice::iter` instead of `into_iter` to avoid future breakage #316

Closed LukasKalbertodt closed 4 years ago

LukasKalbertodt commented 4 years ago

an_array.into_iter() currently just works because of the autoref feature, which then calls <[T] as IntoIterator>::into_iter. But in the future, arrays will implement IntoIterator, too. In order to avoid problems in the future, the call is replaced by iter() which is shorter and more explicit.

A crater run showed that your crate is affected by a potential future change. See https://github.com/rust-lang/rust/pull/65819 for more information.

sebcrozet commented 4 years ago

Thanks!

LukasKalbertodt commented 4 years ago

@sebcrozet Do you think this could be release as 0.21.1? Quite a few crates depend on ncollide, so getting this fix out as soon as possible would be really great :)