dimforge / ncollide

2 and 3-dimensional collision detection library in Rust.
https://ncollide.org
Apache License 2.0
921 stars 107 forks source link

Updated to nalgebra 0.31, Fixed wasm support by indirectly enabling the 'js' feature as fallbac… #380

Open Exiled1 opened 1 year ago

Exiled1 commented 1 year ago

So this seems to be a bottleneck towards updating the nalgebra version, which is having issues for upstream crates. I noticed that the only thing preventing a direct upgrade was this error

    |     ^^^ use of undeclared crate or module `imp`

Which after some searching, was an issue with the rand crate relying on getrandom and its "js" feature. After following the Indirect Dependencies steps, all of the tests in cargo test passed and the CircleCI passed.

Hopefully this should be a relatively instant PR for updating nalgebra to the latest version.