Add `bytecheck` validation to `Archive` types

dimforge / parry

2D and 3D collision-detection library for Rust.

https://parry.rs

Apache License 2.0

529 stars 93 forks source link

Add `bytecheck` validation to `Archive` types #128

Closed bonsairobo closed 1 year ago

bonsairobo commented 1 year ago

In particular I need Aabb: CheckBytes<C>.

Unfortunately I think we will want to wait until a new release of rkyv that contains this PR: https://github.com/rkyv/bytecheck/pull/31

We could work around that issue by providing a manual impl.

samlich commented 1 year ago

Fortune!? There are no accidents. I suppose I should've opened a draft before. I've opened #130, but it depends on another change which makes adding a separate bytecheck dependency no longer required. I'm thinking he might make a release after the AlignedVec changes are done, but if not, I can give him a poke.

samlich commented 1 year ago

Sorry, I should've got back to this sooner.

@djkoloski, could you consider making a new release of rkyv sometime soon. It's my favoritest crate :pleading_face:.

djkoloski commented 1 year ago

Sorry for the delay, 0.7.41 is out now. Does it contain the changes you needed?

samlich commented 1 year ago

Yes, many thanks. PR is now marked as ready.