search

dimforge / parry

2D and 3D collision-detection library for Rust.
https://parry.rs
Apache License 2.0
529 stars 93 forks source link

deps: Update `indexmap` from `1` to `2` #158

Closed waywardmonkeys closed 2 weeks ago

waywardmonkeys commented 10 months ago

This is only used when enhanced-determinism is enabled.

waywardmonkeys commented 10 months ago

There's an interesting detail here in that even before this, the tests fail for cargo test --features enhanced-determinism,serde-serialize ... but they fail same way with and without this update. (Should probably file a bug about that test failure...)

waywardmonkeys commented 10 months ago

This fails for the cuda build as that uses a set version of the nightly from 2021 and hashbrown, a dependency of indexmap has an MSRV of 1.64.

It feels like this will become an increasingly common issue as many crates are ramping up their MSRV to more recent versions than the old nightly that Cuda support requires.

waywardmonkeys commented 2 weeks ago

@sebcrozet I've rebased this forward and fixed the merge conflicts.

sebcrozet commented 2 weeks ago

Fantastic, thanks!