I added derive(PartialEq) to Shapes that were missing them, where possible.
implemented eq tests for some other shapes.
not sure how to compare heightfields correctly, so that is just false at the moment.
also custom shape type just returns false.
not sure if it's feasible to add PartialEq to the Shape trait bounds. I tried, and it complained due to it being used as a trait object. Perhaps this is possible, and there's a way to remove the big match statement?
Would love a review and advice on what to do about custom/heightfield.
I added
derive(PartialEq)to Shapes that were missing them, where possible.implemented eq tests for some other shapes.
not sure how to compare heightfields correctly, so that is just false at the moment.
also custom shape type just returns false.
not sure if it's feasible to add
PartialEqto theShapetrait bounds. I tried, and it complained due to it being used as a trait object. Perhaps this is possible, and there's a way to remove the big match statement?Would love a review and advice on what to do about custom/heightfield.
Thanks!
see #51