dimforge / rapier

2D and 3D physics engines focused on performance.
https://rapier.rs
Apache License 2.0
3.94k stars 248 forks source link

Building rapier with enchanced determinism fails #738

Open Ughuuu opened 5 hours ago

Ughuuu commented 5 hours ago

When building getting:

error[E0061]: this method takes 1 argument but 0 arguments were supplied
   --> crates/rapier2d/../../src/pipeline/physics_pipeline.rs:431:14
    |
431 |             .drain()
    |              ^^^^^-- an argument is missing
    |
note: method defined here
   --> /Users/dragosdaian/.cargo/registry/src/index.crates.io-6f17d22bba15001f/indexmap-2.1.0/src/map.rs:294:12
    |
294 |     pub fn drain<R>(&mut self, range: R) -> Drain<'_, K, V>
    |            ^^^^^
help: provide the argument
    |
431 |             .drain(/* range */)
    |                   ~~~~~~~~~~~~~

error[E0061]: this method takes 1 argument but 0 arguments were supplied
   --> crates/rapier2d/../../src/pipeline/physics_pipeline.rs:432:48
    |
432 |             .chain(multibody_joints.to_wake_up.drain())
    |                                                ^^^^^-- an argument is missing
    |
note: method defined here
   --> /Users/dragosdaian/.cargo/registry/src/index.crates.io-6f17d22bba15001f/indexmap-2.1.0/src/map.rs:294:12
    |
294 |     pub fn drain<R>(&mut self, range: R) -> Drain<'_, K, V>
    |            ^^^^^
help: provide the argument
    |
432 |             .chain(multibody_joints.to_wake_up.drain(/* range */))
    |                                                     ~~~~~~~~~~~~~
Ughuuu commented 5 hours ago

The hashmap for enchanced determinsim is:

#[cfg(feature = "enhanced-determinism")]
pub type FxHashMap32<K, V> = indexmap::IndexMap<K, V, std::hash::BuildHasherDefault<FxHasher32>>;
Vrixyz commented 3 hours ago

Opened https://github.com/dimforge/rapier/pull/739 to discuss that ; I'd like to add a check on CI about that but warnings are annoying 🤔