search

dimforge / rapier

2D and 3D physics engines focused on performance.
https://rapier.rs
Apache License 2.0
3.97k stars 248 forks source link

Clean up warnings #92

Closed emilk closed 3 years ago

emilk commented 3 years ago

There are half a dozen or so warnings generated when building rapier3d (unused imports and unused functions). Ignoring these warnings when compiling may lead to us ignoring more serious warnings.

It would be good to forbid warnings in CI and/or by adding this to lib.rs:

#![cfg_attr(not(debug_assertions), deny(warnings))] // Forbid warnings in release builds
sebcrozet commented 3 years ago

Using deny(warnings) is considered a bad practice so disabling warnings on the CI sounds like the right option. This will be part of #79: it's a large refactoring so I might as well fix all the warnings there and add the CI check.

sebcrozet commented 3 years ago

Sorry, I closed this by mistake, reopening.