search

dimforge / simba

Set of mathematical traits to facilitate the use of SIMD-based AoSoA (Array of Struct of Array) storage pattern.
Apache License 2.0
290 stars 29 forks source link

Implement Sum and Product traits for fixed point numbers #47

Closed richardhozak closed 8 months ago

richardhozak commented 1 year ago

This makes it so simd_horizontal_sum and simd_horizontal_product can be implemented for fixed point numbers.

f32 and f64 have these traits implemented in std, we need to implement them manually so fixed point numbers can be used instead floating point numbers

hatmajster commented 10 months ago

Hello, I understand that this PR can be closed, as it has been developed more in #48 ?

richardhozak commented 10 months ago

Yes, the linked PR contains these changes. This is just subset, so it could be reviewed more easily. If it is desirable, this can be closed in favor of #48.

hatmajster commented 10 months ago

I am not maintainer obviously, but its already in review for few months with no response. you can see exact same commit in the second PR, so its nicely splitted and you can clearly see this subset there. So I would close this one. I just wanted to say that i like this change, and if you need any help I can try and help you.