search

diminish7 / rave

A Google Wave robot client framework for Ruby
http://github.com/diminish7/rave
MIT License
62 stars 8 forks source link

Following references can raise error if the model component is missing from the event data #4

Closed bil-bas closed 14 years ago

bil-bas commented 14 years ago

Need to auto-generate these referenced components, but mark them with a virtual? flag to ensure that users can tell that they aren't completely defined.

bil-bas commented 14 years ago

Pushed something that mostly fixes this earlier, but I think some are still getting through as nil.id is not an error, but rather a warning about that method being deprecated and thus it is almost impossible to guess what part of the code is broken.

bil-bas commented 14 years ago

This should work fine now, but I'm sure something will have slipped through. Bit worried about BlipDeletedEvent#blip, since I don't know whether I can tell if the blip is deleted or destroyed. Hmm, maybe I can now I think about it. Still, "mostly" working is good enough for the immediate time.

bil-bas commented 14 years ago

Just decided to bin virtual blips. Hope I don't regret it...