search

dimitri / el-get

Manage the external elisp bits and pieces upon which you depend!
http://tapoueh.org/emacs/el-get.html
1.65k stars 456 forks source link

Support latest magit update #2690

Closed nanjj closed 5 years ago

tarsius commented 5 years ago

Does el-get normally create an autoloads file for packages that it installs? I think it should.

Create an empty autoloads file because magit.el explicitly checks for a file of that name.

Please create a proper autoloads file instead. You can use make loaddefs for that.

ericdanan commented 5 years ago

Does el-get normally create an autoloads file for packages that it installs? I think it should.

It does but stores autoloads for all packages in a common file. If I understand correctly, magit specifically wants the file magit-autoloads.el to exist, so the el-get recipe creates an empty file with that name.

nanjj commented 5 years ago

fixed

ericdanan commented 5 years ago

Tnanks @nanjj . You may have overlooked @tarsius comment that transient no longer depends on lv, so the hydra dependency can be dropped entirely.

tarsius commented 5 years ago

And with-editor does not need emacs-async.

nanjj commented 5 years ago

Got and Fixed