search

dimitri / el-get

Manage the external elisp bits and pieces upon which you depend!
http://tapoueh.org/emacs/el-get.html
1.64k stars 457 forks source link

Replace deprecated cl by cl-lib #2792

Closed stephan-cr closed 2 years ago

stephan-cr commented 3 years ago

Since Emacs 27, the package cl is deprecated (and issues a warning: Package cl is deprecated). The replacement for cl is cl-lib.

I would like to provide a PR which ports all el-get code to use cl-lib, instead of cl. For this, it would be best to drop support for Emacs versions less than 24.3, because since Emacs 24.3, cl-lib is builtin and doesn't need an extra package from ELPA.

What do you think, can I go ahead?

yyr commented 3 years ago

I think its reasonable to drop support for <24.3. its almost 8 years passed since 24.2 is released. I still come across earlier versions of emacs on some linux servers that I use, but again with so many incompatibilities, now a days I tend to install latest version of emacs in home directory on those servers.

So yes, I support such change.

thoni56 commented 3 years ago

As Emacs now issues a deprecation warning, it is time ;-)

I tried just simple-minded replace all (require 'cl) with (require 'cl-lib) which seems to be the prefered replacement, but the tests did not run with that change...

EDIT: I missed the PR, thanks @stephan-cr

stephan-cr commented 2 years ago

PR has been merged, therefore, it can be closed.