search

dimitri / el-get

Manage the external elisp bits and pieces upon which you depend!
http://tapoueh.org/emacs/el-get.html
1.64k stars 457 forks source link

Add ampl mode #2813

Closed vmiheer closed 2 years ago

stephan-cr commented 3 years ago

I think the correct way to fix upstream, would be:

;;;###autoload
(defun ampl-mode () ...)
vmiheer commented 3 years ago

Thanks, sorry, I missed the location while editing in github website. 🤦‍♂️ Fixed https://github.com/vmiheer/ampl-mode/blob/patch-1/emacs/ampl-mode.el.

stephan-cr commented 3 years ago

I wouldn't autoload auto-mode-alist, see https://www.gnu.org/software/emacs/manual/html_node/elisp/When-to-Autoload.html.

And I would remove

(autoload 'ampl-mode "Ampl" "Entering Ampl mode..." t)

since it is the wrong place for this.

vmiheer commented 3 years ago

@stephan-cr, do we know what's going on with the PRs? This has been open for over a month.