search

dimitri / el-get

Manage the external elisp bits and pieces upon which you depend!
http://tapoueh.org/emacs/el-get.html
1.64k stars 457 forks source link

recipes/cmake-mode: Update location of source and website. #2826

Closed ruediger closed 3 years ago

ruediger commented 3 years ago

Locations have moved.

stephan-cr commented 3 years ago

@ruediger This is a duplicate of #2812. But the title is much more descriptive.

vmiheer commented 3 years ago

Note the url is slightly different:

--- https://gitlab.kitware.com/cmake/cmake/-/raw/master/Auxiliary/cmake-mode.el
+++ https://gitlab.kitware.com/cmake/cmake/-/raw/master/Auxiliary/cmake-mode.el?inline=false

https://gitlab.com/gitlab-org/gitlab/-/issues/23949

Also who does actual merge? This is the second PR of mine which has competing PR :).

stephan-cr commented 3 years ago

Note the url is slightly different:

Not sure, what's the difference. @ruediger could you clarify?

This is the second PR of mine which has competing PR :).

I cannot say much about your first PR, but the second one, I would say the recipe name is missing in the title, that's why it could easily overlooked.

ruediger commented 3 years ago

Regarding URL: Not sure if the ?inline=false is necessary. I copied it from the page. But it requires using the :localname parameter (otherwise the file will be called cmake-mode.el?inline=false). I don't have a strong opinion about that or which PR to merge. I didn't know the other one existed and just wanted to fix the mode.