search

dimitri / el-get

Manage the external elisp bits and pieces upon which you depend!
http://tapoueh.org/emacs/el-get.html
1.64k stars 457 forks source link

Unbreak el-get-remove-autoloads for Emacs < 28 #2835

Closed stephan-cr closed 3 years ago

stephan-cr commented 3 years ago

Starting from Emacs 28 the function autoload-file-load-name takes two non-optional parameters, but versions before Emacs 27 still takes only one. Furthermore, replace string-join by mapconcat, because string-join doesn't exist before Emacs 24.4.

This PR fixes #2833.

stephan-cr commented 3 years ago

@tarao @vedang Could you help out to check these changes for Emacs 28?

vedang commented 3 years ago

Yes, will do this over the weekend and get back to you

On Sat, Jun 12, 2021, 2:00 AM stephan-cr @.***> wrote:

@tarao https://github.com/tarao @vedang https://github.com/vedang Could you help out to check these changes for Emacs 28?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dimitri/el-get/pull/2835#issuecomment-859895556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUUHT32SKNFXS23ET2G3DTSJW7XANCNFSM46RKPMTQ .

vedang commented 3 years ago

:+1:

Tested that removing an installed package works. Tested that reinstalling the removed package works.

LGTM.

tarao commented 3 years ago

Thank you, guys!