dimitri / el-get

Manage the external elisp bits and pieces upon which you depend!
http://tapoueh.org/emacs/el-get.html
1.64k stars 457 forks source link

Update all recipes of the Magit organization to follow the new magit conventions #2855

Closed vedang closed 2 years ago

vedang commented 2 years ago

Recently, @tarsius changed the file layout for the majority of his recipes (as described here: https://github.com/melpa/melpa/commit/325cca8031b99c6abe2ee9858a6b547d1af0cdde)

This breaks the associated el-get recipes. This PR fixes the affected recipes. The following changes are included in the PR on top of 9353309744e4f8a7c9b1adf22ec99536fb2146b0:

  Update recipe for epkg
  Update recipe for ghub
  Update recipe for with-editor
  Update recipe for transient
  Minor style changes to magit and forge recipes

Summary of changes:

recipes/epkg.rcp        |  9 ++++++++-
 recipes/forge.rcp       |  6 ++++--
 recipes/ghub.rcp        | 10 +++++++++-
 recipes/magit.rcp       |  2 ++
 recipes/transient.rcp   |  1 -
 recipes/with-editor.rcp |  9 ++++++++-
 7 files changed, 32 insertions(+), 6 deletions(-)
vonavi commented 2 years ago

Hi @vedang ! I also suggest to replace line :info "Documentation" by :info "docs" in magit.rcp itself. This change reflects recent movement of the documentation subdirectory, which you already took into account for other recipes.

vedang commented 2 years ago

Oh, looks like I missed it. Will make the change and push again.

On Thu, Jan 6, 2022, 12:14 PM Vladimir Ivanov @.***> wrote:

Hi @vedang https://github.com/vedang ! I also suggest to replace line :info "Documentation" by :info "docs" in magit.rcp itself. This change reflects recent movement of the documentation subdirectory, which you already took into account for other recipes.

— Reply to this email directly, view it on GitHub https://github.com/dimitri/el-get/pull/2855#issuecomment-1006323542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUUHST5Y2LACZCU34SB3DUUU24PANCNFSM5K7RVPDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

vedang commented 2 years ago

Pushed the change to the magit recipe as well

vedang commented 2 years ago

Gentle reminder to get this merged in, as it is breaking the installation flow for critical libraries.

vedang commented 2 years ago

Gentle reminder once more! :D I won't bother you folks again for a few months post this.

vedang commented 2 years ago

Hello! It's been 2 months since I last messaged you to request that this PR be merged in! This is your periodic reminder! :)

(Once you merge these changes in, I'm ready with a new batch of recipe updates to push)