dimitri / el-get

Manage the external elisp bits and pieces upon which you depend!
http://tapoueh.org/emacs/el-get.html
1.64k stars 457 forks source link

Add / Update recipes for qpdf.el, pdf-tools and elisp-tree-sitter #2882

Closed vedang closed 1 year ago

vedang commented 1 year ago
vedang commented 1 year ago

That makes sense, let me push a patch

On Thu, Nov 3, 2022, 4:23 PM Alex Ott @.***> wrote:

@.**** commented on this pull request.

I'm not sure about removal of emacs-tree-sitter without deprecation stage

In recipes/emacs-tree-sitter.rcp https://github.com/dimitri/el-get/pull/2882#discussion_r1012748343:

@@ -1,10 +0,0 @@ -(:name emacs-tree-sitter

we need to think how to deprecate it without breaking existing setups... Maybe not remove completely, but add a warning that people need to switch to a new version

— Reply to this email directly, view it on GitHub https://github.com/dimitri/el-get/pull/2882#pullrequestreview-1166665251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUUHVFKUBAIHHLLP7MGNLWGOKS5ANCNFSM6AAAAAARV6YBIU . You are receiving this because you authored the thread.Message ID: @.***>

vedang commented 1 year ago

I've pushed a patch and replied to the review comment, please review again, thanks!