Emacs 29 fix - make-directory behavior

[nevsan]

The behavior of make-directory changed such that it will return t if the directory exists, rather than always returning nil. Here, we update the conditional so that it ensures that ps is not a list, instead of just checking if null.

[renard]

Thanks for this patch. Wouldn't something like

((or (and (< emacs-major-version 29) (null ps)) (not (consp ps)) .... )

be more appropriate?

Long story short: keep current behaviour up to emacs below 29 or use your trick otherwise?

And can you also please add a comment in git commit message referring to emacs commit bef1edc9cacb976120dff73b4d7bbdce6ade982b which introduce that change and the reason for your patch? That would be appreciated.

TIA

[saffroy]

Fixed in #2890

[alexott]

closing as fixed