dimitri / pgloader

Migrate to PostgreSQL in a single command!
http://pgloader.io
Other
5.45k stars 548 forks source link

debian package version 3.6.9-1 mismatch with sources version 3.6.7 #1534

Open mduret opened 1 year ago

mduret commented 1 year ago

Hello,

on a Debian 11

the command version:

pgloader --version

result

pgloader version "3.6.7~devel"
compiled with SBCL 2.1.1.debian

if a look at the installed pgloader package:

dpkg -l | grep pgloader

result:

ii  pgloader                      3.6.9-1.pgdg110+1              amd64        extract, transform and load data into PostgreSQL

the description of the package:

apt-cache show pgloader

result:

Package: pgloader
Version: 3.6.9-1.pgdg110+1
Architecture: amd64
Maintainer: Dimitri Fontaine <dim@tapoueh.org>
Installed-Size: 29846
Depends: freetds-dev, libc6 (>= 2.28), zlib1g (>= 1:1.1.4), libsqlite3-0, libssl1.1
Homepage: https://github.com/dimitri/pgloader
Priority: optional
Section: database
Filename: pool/main/p/pgloader/pgloader_3.6.9-1.pgdg110+1_amd64.deb
Size: 26892484
SHA256: 5be45fbc079e91877d2a7f9c4b080495347de6d3e35357cc89dbd895fbf8bfd2
SHA1: 67186d212560ccc35b1c805ae9c472bd58f83a68
MD5sum: d575966ab8ef79123c021ee9a286876b
Description-en: extract, transform and load data into PostgreSQL
 pgloader imports data from different kind of sources and COPY it into
 PostgreSQL.
 .
 The command language is described in the manual page and allows one to
 describe where to find the data source, its format, and to describe data
 processing and transformation.
 .
 Supported source formats include CSV, fixed width flat files, dBase3 files
 (DBF), and SQLite and MySQL databases. In most of those formats, pgloader
 is able to auto-discover the schema and create the tables and the indexes
 in PostgreSQL. In the MySQL case it's possible to edit CASTing rules from
 the pgloader command directly.
Description-md5: c3276f31c13a9fa328d545c55fb29249

so the version of the binary is 3.6.7 and the version of debian package is 3.6.9-1.

I had a look at the coresponding tag:

after a research into the code of the corresponding commit of the 3.6.9-1 tag:

I find a non-corresponding minor version:

(defparameter *minor-version* "7")

instead of having the value 9.

I think it is a careless mistake.

I propose to create 3.6.9-2 tag with the correct correspondance between code and tag.

How can I help or can anyone fix the problem ?

Thank you and have a good day,

mduret commented 1 year ago

hello again,

the diff between commits:

git diff $(git show-ref -s v3.6.9) $(git show-ref -s debian/3.6.9-1)

it is not about this issue:

diff --git a/debian/rules b/debian/rules
index f22032b..37f902e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -57,6 +57,7 @@ override_dh_auto_build-arch:
                        || echo $$? > buildapp.fail
        cat buildapp.log
        test ! -f buildapp.fail
+       ls -l build/bin/pgloader
        $(MAKE) -C docs html

 override_dh_auto_test:

in v3.6.9 tagged code:

git checkout v3.6.9

verification:

cat src/params.lisp | grep 'defparameter' | grep 'minor-version' 

result:

(defparameter *minor-version* "7")

The problem seems to be an incorrect value of minor version into the code under the tag v3.6.9.

I hope it could help