search

dimitri / pgloader

Migrate to PostgreSQL in a single command!
http://pgloader.io
Other
5.45k stars 548 forks source link

fix: mssql should only load data for the views specified by materialize views #1559

Open conoremclaughlin opened 9 months ago

conoremclaughlin commented 8 months ago

Hi @svantevonerichsen6906, thanks for the comments. I wanted to get the PR up for anyone who found it useful before cleaning it up.

I've removed the debug statements and have changed the parentheses to follow more of Lisp's standards. Unfortunately it's been quite some time since I learned Lisp in Berkeley and Lisp doesn't have a good formatter, so this is about as far as I can go for formatting. If you can give me some more specifics I can address them! Otherwise I would run the formatter across the file. The original code's indentation formatting was also off. It's also specifically noted that this flow was untested by the author, so anything is an improvement over the untested / completely broken materialize views code path we currently have for MSSQL.

Thanks!

conoremclaughlin commented 8 months ago

Fixes #1551.

conoremclaughlin commented 5 months ago

Bumping this @svantevonerichsen6906. Thanks man!