dimitriosxmi / ArtistsReferenceOrganizer

Neue Fische Capstone Project
https://artists-reference-organizer.vercel.app
0 stars 0 forks source link

Feature/us8/folder view #27

Closed dimitriosxmi closed 1 year ago

dimitriosxmi commented 1 year ago

Please take a moment to review this ❤️ Goal: US8 TL; DR: Add a Folder view page accessible through a click on an existing folder, creating new entry from a folder sets the folder selection of the entry to the specific folder it was called from.

Deployment

+ Add folder/[folderId].js page
# Displays the entry list of a folder.

! Update Breadcrumb component
# To support the new page and deliver an adaptive breadcrumb.

! Update entries.js api page
# Handles the GET method for specific folderId related entries.

! Update EntryPreviewList component
# Added fetch with folderId router params to get only entries of the specific folder.

! Update FolderPreviewButton component
# Renamed from FolderPreviewIcon to FolderPreviewButton.
# Uses a link now instead of a div.

! Update FolderPreviewList component
# Applies the new FolderPreviewButton component name.

! Update folder.js api page
# Handles the GET method for getting a folder by id.

! Update NewEntryButton component
# Catches from props the folderId and provides it with the new route.

! Update NewEntryForm component
# Catches the folderId router param and provides it to the newly created entry
# if the entry doesn't already have a selected folder Id value.
dimitriosxmi commented 1 year ago

Nice work! 🚀 Please see just a tiny comment 🙂

* and reviewing your deployment: your `new entry button` has some styling issues, the text is at the lowest z-index (so it gets partially covered by the folder icon)

Cheers, Thomas

Heyo Thomas, Thank you for your time and your for your review! 😊 This is intentional design, I can see perhaps next week if by then I'll be done to consider changing the design of the entire app or parts like this NewEntryButton components 😋

MichanNan commented 1 year ago

LGTM i really like the comments you write, that makes it easier to read the code!