search

dimitriv / Ziria

A domain-specific-language and compiler for low-level bitstream processing.
92 stars 18 forks source link

BlinkDiff refactor and new flag #122

Closed ghost closed 8 years ago

ghost commented 8 years ago

Minor refactor of BlinkDiff which should fix line ending issues, some syntactic changes, and a new flag which should improve diff accuracy in receiver tests.

dimitriv commented 8 years ago

Safe to merge? I don't have time to properly test but I trust you. Also I noticed some changes to an actual infile, were these important?

ghost commented 8 years ago

The infile was renamed to use different BlinkDiff arguments for OFDM.

I wanted to double check on the changes to the receiver tests (in code/WiFi/receiver/tests/Makefile). This should set tougher requirements for the receiver tests. From what I've noticed so far, the receiver tests are accurate within 90% accuracy assuming that a deviation of 1.0 is ignored (for small values where 10% is less than 1.0). The only exception is OFDM where values under 25.1 have a fairly large deviation. I think this is better solution than setting a threshold of 220, since values below the threshold value will be accepted even if they are terribly off.

Assuming that's fine, it should be safe to merge.

ghost commented 8 years ago

Closed via https://github.com/dimitriv/Ziria/commit/c7e49aa5e84450b46a9df16892ed428558029535