search

dimitrov-adrian / directus-extension-searchsync

Simple Directus 9 extension that sync content with remote search engine.
MIT License
116 stars 27 forks source link

Feat/filter indexed text #3

Closed Jonesus closed 3 years ago

Jonesus commented 3 years ago

Adds an option to filter all html tags from text before indexing them

Branched on my two previous pull requests, so the two first commits don't really belong here

I'm starting to think that this kind of architecture isn't optimal, would a better way maybe be to change the configuration file from json to js or something, where it would be easier for users to embed their own case-by-case data transformers for better indexing?

dimitrov-adrian commented 3 years ago

Many thanks for the PRs. I just changed html stripping to use https://www.npmjs.com/package/striptags as a bit more mature way.

I'm starting to think that this kind of architecture isn't optimal, would a better way maybe be to change the configuration file from json to js or something, where it would be easier for users to embed their own case-by-case data transformers for better indexing?

Yes, I am on this too. Not sure how to structure it so to provide most convenient way for configuration. If you have any particular idea, just file an issue or PR