search

dimkr / loksh

A Linux port of OpenBSD's ksh
115 stars 6 forks source link

CTRL is not defined when building 6.8 against musl #30

Closed dimkr closed 3 years ago

wylfen commented 3 years ago

Just ran into this on one of my musl systems, even with the patch applied (i.e with 6.8). Is there a reason the header is only included when SMALL is set? I'm building loksh against ncurses, so the header is never pulled in for me.

Also whilst I'm here, the version number in meson.build is still 6.7. Thanks!

dimkr commented 3 years ago

Somehow, CTRL is defined when building against ncurses. I had to dig into headers, and found out that term.h or some other ncurses header eventually #includeded sys/ttydefaults.h, so CTRL is undefined only when SMALL. Can you attach a build log?

wylfen commented 3 years ago

I've attached a build log.

I'm using ncurses 6.2 and couldn't find sys/ttydefaults.h in any of its headers. Which header is it exactly that has it included for you?

dimkr commented 3 years ago

term.h (from ncursesw) includes termios.h, which includes sys/ttydefaults.h.