Closed dimmus closed 11 months ago
Have a huge passion to try the acr as well.
ACR tries to replace autoconf functionality generating a full-compatible 'configure' script (runtime flags). But using shell-script instead of m4. This means that ACR is faster, smaller and easy to use.
From a quick look at your meson branch I think it can be simplified a lot. At least the following:
PACKAGE_*
defines by default, but you do not actually use them so just don't bother? All you need basically is PACKAGE_NAME alone.eflete_cargs = '-fvisibility=hidden'
and checking if the compiler supports it is not necessary, you can use Meson's gnu_symbol_visibility: 'hidden'
kwarg and Meson will handle this for you== true
, you're checking if a function that returns a boolean, is equal to boolean true. if true == true
then evaluates and returns the value true
, and if true
runs the code inside that block; you can just use if func('thing')
e.g. if cc.has_argument(cf)
cc.get_supported_arguments()
which returns a list of the supported ones. eflete_cflags = cc.get_supported_arguments(eflete_cflags_try)
c_args: [..., '-I' + join_paths(meson.source_root(), 'src/bin/alloc'), ...]
should just be include_directories: [..., 'src/bin/alloc', ...]
, you can avoid specifying the current source directoryEli, thanks. Highly informative. Certainly, i take a look.
You leveled up my meson skills :)
No problem :) I'm happy to give a more thorough review as that branch progresses, feel free to ping me.
Fully switched to meson build system. Done!
Time to think about meson wrap
support.
Not sure, but it might be worth switching to meson build system. Eflete is not a huge package, so the compilation speed is not extremely critical issue.
Personally, i like good old autotools.