search

dimmyvi / tigress-requirements

Other
0 stars 3 forks source link

Fix the sequence diagrams #42

Closed snorp closed 1 year ago

snorp commented 1 year ago

There is a regression in svgcheck that seems to break svg generation. You may also need the following change in lib/ to make things build.

diff --git a/requirements.txt b/requirements.txt
index a1c530a..e77476b 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -3,6 +3,6 @@ iddiff
 pyang
 pyyaml
 rfc-tidy
-svgcheck
+svgcheck == 0.6.2
 toml
 xml2rfc
snorp commented 1 year ago

Yup, need that Makefile fix as well, but I guess I need to figure out the svgcheck issue. Downgrading it made things work for me here, but I can't make it break again by installing 0.7.1, so now I'm wondering if it's some dependency of svgcheck that's actually causing the problem.

dimmyvi commented 1 year ago

svgcheck manual version fix works for local build, but github auto build fails. I can try manually publish the doc with fixed diagrams.

snorp commented 1 year ago

There's a workaround in the latest kramdown-rfc (https://github.com/cabo/kramdown-rfc/issues/187) so things might be fine if we just rekick the jobs.

dimmyvi commented 1 year ago

@snorp, applied chnages from this PR inhttps://github.com/dimmyvi/tigress-requirements/pull/47 - due to failing checks here. #47 merged successsfully.