dimok789 / homebrew_launcher

WiiU Homebrew Launcher
GNU General Public License v3.0
406 stars 94 forks source link

Exit: Home launches Wii U Menu, Minus launches Mii Maker #60

Closed vaguerant closed 2 years ago

vaguerant commented 2 years ago

@Fangal-Airbag proposed roughly this change in the Aroma Discord, adding "if anyone wants to PR that have fun!" So I'm having fun.

The original suggested change by Fangal-Airbag simply added Minus to launch the Wii U Menu, whereas this version does the following:

Home -> Wii U Menu Minus -> Mii Maker

This might be a controversial change since Home has gone to Mii Maker for so long that people may be used to it behaving that way, but I hold pretty strongly that people naturally expect Home to allow them to quit, not reload into Mii Maker. In particular, users of the HBL channel are accustomed to using Home to quit. Most users only need Mii Maker fairly infrequently, so making it the secondary exit state seems reasonable to me.

I've been running this build locally for a few days and also posted it on Discord. No complaints so far.

Test build: https://cdn.discordapp.com/attachments/433673797522948097/937288463986864258/homebrew_launcher.elf

Bonus test build, also includes #59: https://cdn.discordapp.com/attachments/839753467056357376/938231179709149204/homebrew_launcher.elf

This PR is largely a dupe of #39, but uses different buttons to achieve the same thing.

Maschell commented 2 years ago

I would appreciate if you could update the UI to somewhere mention where to exit to the Mii Maker

vaguerant commented 2 years ago

Compared to your patch, I slightly increased the font size and fudged around with the pixel offsets a little just to get the aliasing on the text to look decent (i.e. have the two is in Mii appear the same width). The font is a little finer than the one used in the rest of the app and the Minus button is especially fine, so I wanted to be sure the button glyph was legible. If you prefer your original sizing, feel free to adjust before merging.