Don't use chardet unless you have to

dimones / feedparser

Automatically exported from code.google.com/p/feedparser

Other

0 stars 0 forks source link

Don't use chardet unless you have to #421

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Automatic character set detection can be CPU intensive, especially with large 
feeds. It seems a waste to run it on every feed, considering that the result 
will be discarded most of the time.

The attached patch makes the chardet invocation lazy.

Original issue reported on code.google.com by itsa...@gmail.com on 20 Jan 2014 at 8:40

Attachments:

lazy_chardet.patch

GoogleCodeExporter commented 9 years ago

Thanks for this patch! Assuming feed correctness (in this day and age) can save 
a lot of cycles in this day and age, and I'm excited about the possibility of 
making feedparser faster and less processor hungry!

Original comment by kurtmckee on 10 Jul 2014 at 2:16

Changed state: Accepted