search

dimonomid / geekmarks

API-Driven, Geeky Bookmarking Service
BSD 2-Clause "Simplified" License
577 stars 39 forks source link

Go code formatting fixes #12

Closed kshitij10496 closed 7 years ago

kshitij10496 commented 7 years ago

Using the gofmt tool, I found the code was not compatible with the standard coding style guide. If we do not intend to follow the Styling guide, do let me know.

This change is Reviewable

dimonomid commented 7 years ago

Hi, thanks.

My editor runs gofmt for all files I edit, but this file bindata_assetfs.go is autogenerated, see in server/server.go:

//go:generate go-bindata-assetfs -pkg server -nocompress -modtime 1 -mode 420 webroot/...

So if we care about its formatting, we should incorporate gofmt in the autogeneration process.

kshitij10496 commented 7 years ago

Hey @dimonomid

So if we care about its formatting, we should incorporate gofmt in the autogeneration process.

I agree. This would be a more robust way to solve the formatting problem. Since I'm currently learning Go and familiarising with its development workflow, I will try to look for resources for solving this.