dimonovdd / Xamarin.MediaGallery

This plugin is designed to picking and save images and video files from native gallery of Android and iOS devices and capture photos
MIT License
151 stars 18 forks source link

remove Xamarin support #129

Closed dimonovdd closed 6 days ago

dimonovdd commented 1 week ago

Related to issue

128

124

API Changes

remove Xamarin support

Recommendations for testing

PR Checklist

dimonovdd commented 1 week ago

@beeradmoore Hi

Sorry, Maybe, do you have a desire to do a review? I also plan to make a separate pull request to improve the sample project.

beeradmoore commented 1 week ago

Yep. I'll give this a look at this weekend 👍

dimonovdd commented 1 week ago

@beeradmoore This pull request came out too big and confusing, I'm trying to shorten it.

beeradmoore commented 1 week ago

I don't see it as that. Most of the changes are deleting the old sample and adding the new.

dimonovdd commented 1 week ago

Most of the changes are deleting the old sample and adding the new.

It seems that I have corrected all this. But I don't want to deal with the MAUI versions here. Individual small PRswill be more visual and understandable

dimonovdd commented 1 week ago

@beeradmoore tell me what fixes do you consider really critical? I have already prepared two new branches and am ready to create a Pull Requests. But first we need to merge this Pull Request

beeradmoore commented 1 week ago

I don't see anything else here as critical for a preview release. MAUI versions stuff I'd like to experiment with for a full release.

Once its in I'd like to look into getting it to build nugets with dotnet pack as an ease of convieneince for pumping out local nuget packages to experiment with the MAUI version stuff.

Good job updating it all!

EDIT: There were 2 other .DS_Store files that hung around

Sample/Platforms/.DS_Store
Sample/Resources/.DS_Store
dimonovdd commented 6 days ago

@beeradmoore thx, I deleted .DS_Store files. Would you approve this Pull Request?

beeradmoore commented 6 days ago

@dimonovdd , I don't see an option to approve, just squash and merge.

Unless you mean verbally, in which case looks good

Edit: found it