dimotsai / agar-mini-map

A minimap which is able to show positions on agar.io

https://github.com/dimotsai/agar-mini-map

MIT License

39 stars 24 forks source link

Added party member crosshairs and slight change in UI #37

Closed borislav-draganov closed 9 years ago

borislav-draganov commented 9 years ago

ADDED: Crosshairs for party members in their respective color CHANGED: position and size of UI windows

dimotsai commented 9 years ago

@borislav-draganov Thanks a lot for implementing crosshairs for party members. I would like to separate this pull request into two part. Would you please open another pull request for UI changes? We should discuss it further.

borislav-draganov commented 9 years ago

Not sure I understood correctly. You want me to cancel this pull request and create two new ones - one for the crosshairs and one for the UI, is that correct? If so I'd appreciate a pointer as to how to do so (honestly, I haven't used GitHub a lot)

dimotsai commented 9 years ago

@borislav-draganov Yes, create two branches - one for the crosshairs and one for the UI. And then you create two pull requests base on the respective branch.

38

dimotsai commented 9 years ago

this document might help you: https://help.github.com/articles/using-pull-requests/#initiating-the-pull-request

borislav-draganov commented 9 years ago

OK, I'll check it out for the UI changes. In the meantime I reverted the commit and made a pull request with only the party member crosshairs. You can look into it and see if you like it