search

dimroc / etl-language-comparison

Count the number of times certain words were said in a particular neighborhood. Performed as a basic MapReduce job against 25M tweets. Implemented with different programming languages as a educational exercise.
http://blog.dimroc.com/2015/11/14/etl-language-showdown-pt3/
186 stars 33 forks source link

Review Elixir implementation #5

Closed dimroc closed 9 years ago

dimroc commented 9 years ago

Hi @josevalim, If you have a minute, could you review my elixir code here? https://github.com/dimroc/etl-language-comparison/tree/master/elixir/lib

It'll be used in my second write up of http://www.dimroc.com/2014/09/29/etl-language-showdown/

josevalim commented 9 years ago

Sure, I will review and send a PR if required shortly!

dimroc commented 9 years ago

Thanks! Just a heads up that these implementations no longer read and write from a reduction file like they did previously.

josevalim commented 9 years ago

Done in #6. Just minor changes. It is also running in 56s on the same machine as my original pull request which brought it from 2m50s to 1m50s.

dimroc commented 9 years ago

Thanks for the help @josevalim