search

dims / etcd3-gateway

This repository is now read-only. Please see https://opendev.org/openstack/etcd3gw for the new location for this code.
https://opendev.org/openstack/etcd3gw
Apache License 2.0
10 stars 20 forks source link

Support for protocol type while creating client. #26

Closed heychirag closed 6 years ago

heychirag commented 6 years ago

Added support for specifying protocol type while calling client().

codecov-io commented 6 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files           7        7           
  Lines         314      314           
  Branches       33       33           
=======================================
  Hits          274      274           
  Misses         25       25           
  Partials       15       15
Impacted Files Coverage Δ
etcd3gw/client.py 85.06% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 224f409...0b6a43d. Read the comment docs.

dims commented 6 years ago

LGTM. thanks for the patch @heychirag

lingxiankong commented 6 years ago

hi @dims, I'm wondering when we could make a release to include this change?

dims commented 6 years ago

@lingxiankong i can cut one tomorrow

lingxiankong commented 6 years ago

thanks a lot!

dims commented 6 years ago

@lingxiankong Done! sorry for the delay