search

dims / etcd3-gateway

This repository is now read-only. Please see https://opendev.org/openstack/etcd3gw for the new location for this code.
https://opendev.org/openstack/etcd3gw
Apache License 2.0
10 stars 20 forks source link

Add a "create" method for the client #3

Closed lihiwish closed 7 years ago

lihiwish commented 7 years ago

Adds a "create" method to the client, which verifies that the key did not exists in the key-value store, before assigning the new value to the key.

dims commented 7 years ago

@lihiwish Can you please rebase against master? I got the travis builds working now

codecov-io commented 7 years ago

Codecov Report

Merging #3 into master will increase coverage by 0.28%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   89.26%   89.54%   +0.28%     
==========================================
  Files           7        7              
  Lines         298      306       +8     
  Branches       29       30       +1     
==========================================
+ Hits          266      274       +8     
  Misses         20       20              
  Partials       12       12
Impacted Files Coverage Δ
etcd3gw/client.py 88.51% <100%> (+0.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b45cf5b...888d261. Read the comment docs.

dims commented 7 years ago

Never mind, figured out how to test this and the change looks good.