Getting deprecated warning on jQuery > 3.3

dimsemenov / Magnific-Popup

Light and responsive lightbox script with focus on performance.

http://dimsemenov.com/plugins/magnific-popup/

MIT License

11.38k stars 3.5k forks source link

Getting deprecated warning on jQuery > 3.3 #1163

Open ravinderk opened 3 years ago

ravinderk commented 3 years ago

I am getting warning about deprecated function jQuery.isFunction() on jQuery > 3.3.

Are we planning to update the code?

pacmanito commented 2 years ago

@dimsemenov Can you please check this one? It should be rather straightforward to implement and will guarantee trouble-free work of library in the future.

hagman commented 1 year ago

Doing so means to no longer support some "legacy browser", but I do not see a problem with that in 2023. There are only a few small fixes (which I was "forced" do do in my local production copy, so I guess I should be able to suggest a proper fix tomorrow.