search

dimsemenov / Magnific-Popup

Light and responsive lightbox script with focus on performance.
http://dimsemenov.com/plugins/magnific-popup/
MIT License
11.38k stars 3.5k forks source link

Scrollbar does not disable on mobile browsers or Chrome responsive mode #1180

Closed gavsiu closed 2 years ago

gavsiu commented 2 years ago

For some reason, margin-right and overflow hidden is not being applied to the html element under certain conditions. This can be tested on Magnific Popup's demo page. Don't forget to refresh after toggling responsive design mode.

Samsung Galaxy S10 Plus - Android 12

Firefox 99.1.1 (Build #2015871915): scrolls Chrome 100.0.4896.79: scrolls

Arch Linux - browsers in normal mode

Firefox 98.0.2: does not scroll Chromium 100.0.4896.60 (Official Build): does not scroll

Arch Linux - browsers in responsive design mode

Firefox 98.0.2: does not scroll Chromium 100.0.4896.60 (Official Build): scrolls

Can anyone figure out why?

gavsiu commented 2 years ago

Found out where in the code. Just don't know why it's disabled.

https://github.com/dimsemenov/Magnific-Popup/blob/c8f6b8549ebff2306c5f1179c9d112308185fe2c/dist/jquery.magnific-popup.js#L144