dimsemenov / Magnific-Popup

Light and responsive lightbox script with focus on performance.
http://dimsemenov.com/plugins/magnific-popup/
MIT License
11.38k stars 3.5k forks source link

Fix dart sass division "/" syntax error, use calc() instead #1183

Open 9ete opened 2 years ago

9ete commented 2 years ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch magnific-popup@1.1.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/magnific-popup/src/css/_settings.scss b/node_modules/magnific-popup/src/css/_settings.scss
index 75eadbc..88a930b 100644
--- a/node_modules/magnific-popup/src/css/_settings.scss
+++ b/node_modules/magnific-popup/src/css/_settings.scss
@@ -27,7 +27,7 @@ $mfp-include-iframe-type:             true !default;                       // En
 $mfp-iframe-padding-top:              40px !default;                       // Iframe padding top
 $mfp-iframe-background:               #000 !default;                       // Background color of iframes
 $mfp-iframe-max-width:                900px !default;                      // Maximum width of iframes
-$mfp-iframe-ratio:                    9/16 !default;                       // Ratio of iframe (9/16 = widescreen, 3/4 = standard, etc.)
+$mfp-iframe-ratio:                    calc( 9 / 16 ) !default;                       // Ratio of iframe (9/16 = widescreen, 3/4 = standard, etc.)

 // Image-type options
 $mfp-include-image-type:              true !default;                       // Enable Image-type popups

This issue body was partially generated by patch-package.