search

dimsemenov / Magnific-Popup

Light and responsive lightbox script with focus on performance.
http://dimsemenov.com/plugins/magnific-popup/
MIT License
11.39k stars 3.5k forks source link

Sass Compile Issue for .mpf-figure figure margins #421

Open liquidvisual opened 10 years ago

liquidvisual commented 10 years ago

I'm using the Magnific Sass files and all looks perfect except unwanted margins appearing in .mpf-figure figure when compiling. Notice the grey outline below.

unwanted-margins

I wasn't getting this issue with the compiled css from the main website. I ran both files through a comparison tool, and found the difference was the following not coming through in the Sass compile - despite it being there in line 500 of main.scss:

.mpf-figure figure { margin: 0; } /* not appearing in compiled version */

Not sure why this isn't coming through? Is anyone else experiencing this?

liquidvisual commented 10 years ago

Actually, I just realised this seems to be an issue with the scss file that's coming through via Bower. It doesn't have any declarations for .mpf-figure figure at all.