search

dimsemenov / Magnific-Popup

Light and responsive lightbox script with focus on performance.
http://dimsemenov.com/plugins/magnific-popup/
MIT License
11.39k stars 3.49k forks source link

height: 13305px #675

Open hallomatt opened 9 years ago

hallomatt commented 9 years ago

Hi there,

The following javascript seems to produce very high values on long pages - snippet from core.js:

mfp.bgOverlay.css({
    height: _document.height(),
    position: 'absolute'
});

results in: <div class="mfp-bg mfp-fade mfp-ready" style="height: 13305px; position: absolute;"></div>

This could slow down fade animations on slower machines. How about using position: fixed for the bgOverlay?

.mfp-fade.mfp-bg {
    position: fixed;
    top: 0;
    left: 0;
    height: 100%;
    width: 100%;
}

Greetings, Matt

tukvillie commented 4 years ago

Hi it is adding long pages -

any solution for it?