search

dimtoneff / ComfyUI-PixelArt-Detector

Generate, downscale, change palletes and restore pixel art images with SDXL.
MIT License
174 stars 10 forks source link

cleanup_pixels_threshold #8

Closed crotron closed 10 months ago

crotron commented 11 months ago

I am using the default workflow.json file in the repo and am getting an error regarding the cleanup_pixels_threshold input to PixelArt Palette Converter:

image

It seems like this input is unconnected, making the block not run. Even stranger, when I try to resolve this by connecting a primitive to it, ComfyUI silently does nothing. Opening devtools reveals that it appears to have an infinite recursion loop when upon trying to generate.

Uncaught (in promise) RangeError: Maximum call stack size exceeded at widgetInputs.js:22:46 at Array.find (<anonymous>) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:22:32) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:27:45) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:27:45) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:27:45) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:27:45) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:27:45) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:27:45) at widget.serializeValue [as origSerializeValue] (widgetInputs.js:27:45)

dimtoneff commented 10 months ago

Something has changed in Comfy. This field should of been a FLOAT input below cleanup_colors. Somehow now it ends up there... I will have to see what has changed in order to fix it

dimtoneff commented 10 months ago

I checked out Comfy older commits and it works: image

So yea, gotta find what has changed.

dimtoneff commented 10 months ago

Here is the problematic commit:

https://github.com/comfyanonymous/ComfyUI/commit/9a7a52f8b5321e9a67fab18d4f256d2cd6bc338f

There is also a report in ComfyUI repo: https://github.com/comfyanonymous/ComfyUI/issues/1404

Go to the place where it works: git checkout 0e3b64117218c50a554b492269f5f35779839695

dimtoneff commented 10 months ago

Messaged the PR Author...

https://github.com/comfyanonymous/ComfyUI/pull/1104

M1kep commented 10 months ago

Fix should be merged now

dimtoneff commented 10 months ago

Working good @M1kep! Tnx for the fast reaction!

image

dimtoneff commented 10 months ago

@crotron please, update your ComfyUI. Palette Converter should be fine now.

crotron commented 10 months ago

@crotron please, update your ComfyUI. Palette Converter should be fine now.

Thanks, it works!