search

dimven / SpringNodes

A collection of Dynamo nodes
MIT License
69 stars 46 forks source link

Springs.CurveLoop.Simplify #29

Closed ParametricMonkey closed 7 years ago

ParametricMonkey commented 7 years ago

Hi Dimitar

I've been using this node for a while and it always worked perfectly. Now I am running it on Revit 2018 and Dynamo 1.3.1 and the node is failing. There is no error message and my coding isn't good enough to pin point the issue. However, I'm wondering if the issue is due to the new 'geometry working range' setting in Dynamo and the precision.

Thanks

dimven commented 7 years ago

I don't think anything on the Revit side will affect it - it's using only Dynamo entities. I last remember using it in 1.21, so it could be some minor change around the geometry in 1.3/ 1.31. I'll have a look this weekend.

dimven commented 7 years ago

@ParametricMonkey 1) does the below work for you: image

2) and if not, what packages do you have installed

ParametricMonkey commented 7 years ago

@dimven. No, neither work for me.

1

Here are the installed packages

2

dimven commented 7 years ago

@ksobon's archi-lab has a List class that is causing this:

https://github.com/ksobon/archilab_Grimshaw/blob/master/archilabTypes.cs/List/List.cs

As a quick fix, you'll need to prefix each "List" usage with "DSCore."

image

EDIT: Scratch that, namespaces are broken in imperative code ... :(

dimven commented 7 years ago

This seems to be a known issue that can't be resolved at this time: https://github.com/DynamoDS/Dynamo/issues/7697

I'm in the process of fixing all namespace clashes and removing all references to the list class in all imperative blocks. I should have a new version out soon.

dimven commented 7 years ago

Could you give with ver. 121.0.2 ?

ParametricMonkey commented 7 years ago

thanks @dimven. That seems to have worked.