dimven / SpringNodes

A collection of Dynamo nodes
MIT License
69 stars 46 forks source link

Springs.Shaft.ByCurves issues #35

Closed zachbeale closed 7 years ago

zachbeale commented 7 years ago

Hello,

I can't get springs.shaft.BrCurves to work for the life of me. I've tried different configurations of polycurves, both joined and unjoined, and different configurations of levels. Each input has the same list structure, yet all I ever get is a null. Any ideas?

dimven commented 7 years ago

Hi,

Have a look at the "Shaft.ByCurves sample.dyn" and the similarly named revit file inside the samples folder

image

zachbeale commented 7 years ago

Thanks for the fast reply. Your sample is working great, but I don't know why the process isn't working on my file. We have a few special conditions, one, the floor intersection information is being pulled form a linked file, though that shouldn't be an issue because the resulting curves work fine, secondly, we have multiple shafts stretching between multiple levels (the whole point of this is to build shafts for mechanical risers. in the included screenshot i'm only processing four ducts to debug), so our lists are a level more complicated than yours. I'm not sure if I'm doing something wrong with the listing, or the node isn't accepting the leveled lists. Am I missing something? capture

dimven commented 7 years ago

I suspect it's because of your list structure. Try flattening the lists for the base & top levels.

zachbeale commented 7 years ago

I isolated just the first respective top and bottom levels, as well as the first shaft only, and I'm still getting an empty. I've attached the script for you to see. It's very possible I'm doing something wrong, but I'm really not sure. capture3 risers fam create-openings coord anno 05.txt

dimven commented 7 years ago

Not sure why you're getting an empty list. The node should return a null if it fails. If I recreate your list structure however, I get a shaft as expected:

image

Are you on the latest version and if not, could you try updating?