dimven / SpringNodes

A collection of Dynamo nodes
MIT License
69 stars 46 forks source link

Floor opening cuts mess with element sketch (Element Sketch Collector) #45

Open TinaMTH opened 6 years ago

TinaMTH commented 6 years ago

Hi

I don't know that this is actually an issue with the Element Sketch Collector - it might be a Revit issue. But I'm curious to see, if there is a solution to this problem. When I try to collect the element sketch of a floor with a floor opening cut (vertical opening), the output is the outline of one of the openings.

My current solution is to avoid using floor opening cuts, but that is not the most long lasting solution.

Thank you

Tina

TinaMTH commented 6 years ago

I can see where the problem comes from - The Element Sketch Collector relies on the correlation between Sketch Id and Element Id to be: Sketch Id = Element Id -1

But when a floor opening cut is used, the Ids are shifted, and the sketch of one of the openings take over the Sketch Id of Element Id -1.

dimven commented 6 years ago

I tried to be smart and add this as a workaround that avoids rolling back transactions, because that can be very slow on large files. Seems like it's not a solid option tho. I think it's best if there's another input controlling this behavior.

TinaMTH commented 6 years ago

What I did find was, when I set the boolean to false, the curves came out correctly - so I did a very similar procedure to what you did in the script. I did a delete and roll back procedure to collect all the related Ids, then I filtered out the model lines by element name and matched them with the outlines I had found from the curves (found with your node) by the location of the centerpoints.