The changes made in dimxy-fix-staking-array are very good and IMO necessary. Making C-style arrays using malloc/calloc is not something I would recommend to anyone in C++.
The fixes in this PR change no functionality. They only
Make lines shorter for better display in IDEs and GitHub
Remove commented-out lines that are no longer needed
Change array to collection. The word "array" to me puts the wrong idea into my head as to what the object truly is. "Collection" is a bit more generic IMO.
These changes just make the code easier to read IMO. Merge this branch into yours if you wish.
The changes made in dimxy-fix-staking-array are very good and IMO necessary. Making C-style arrays using malloc/calloc is not something I would recommend to anyone in C++.
The fixes in this PR change no functionality. They only
array
tocollection
. The word "array" to me puts the wrong idea into my head as to what the object truly is. "Collection" is a bit more generic IMO.These changes just make the code easier to read IMO. Merge this branch into yours if you wish.