Add workflow to automatically update assets via `nova-kit/nova-packages-tool`

dinandmentink / nova-markdown

Adds a markdown editor component to laravel nova.

MIT License

36 stars 4 forks source link

Add workflow to automatically update assets via `nova-kit/nova-packages-tool` #26

Closed crynobone closed 2 years ago

crynobone commented 2 years ago

laravel-nova will be served via external window.LaravelNova and no longer requires asset rebuild whenever mixins contains any changes.
nova-kit/nova-packages-tool will bump new version after Nova made any minor/patch release before user can received the updated version.
smaller dist files since it no longer build all mixins.

dinandmentink commented 2 years ago

Thanks for the PR. Will have a look tomorrow.

dinandmentink commented 2 years ago

I see still new commits, is this ready for review?

crynobone commented 2 years ago

Yes its ready.

dinandmentink commented 2 years ago

Thanks for the PR @crynobone! It seems to work. Open to merging this but still have a question.

I'm still not entirely sure why this change is necessary. I always perform a build before releasing. Could you please describe the advantage of using nova-packages-tool as an external dependency? It gives me an extra dependency to monitor.

crynobone commented 2 years ago

I always perform a build before releasing.

Currently, you should also always build whenever Nova releases any minor release because it may contain changes that would be incompatible with the previous version.

The nova-packages-tool will take over these changes, your user will only get the latest compatible Nova based on the nova-packages-tool installed.

dinandmentink commented 2 years ago

Thanks for the explanation. I'll work towards releasing this.