added 'slideUp' transition, autoClose, transitionClose, changed delegate / bind to on and off

dinbror / bpopup

bPopup is a lightweight jQuery modal popup plugin (only 1.34KB gzipped). It doesn't create or style your popup but provides you with all the logic like centering, modal overlay, events and more. It gives you a lot of opportunities to customize so it will fit your needs.

http://dinbror.dk/bPopup

427 stars 260 forks source link

added 'slideUp' transition, autoClose, transitionClose, changed delegate / bind to on and off #12

Closed Leonidaz closed 11 years ago

Leonidaz commented 11 years ago

added 'slideUp' transition to have overlay rise from the bottom to the top
autoClose will close overlay automatically if milliseconds are provided
added transitionClose to specify which transition to use on close. If not provided close will use the transition.
changed delegate, undelegate and bind, unbind to on and off -- this will change will require jQuery 1.7 and higher (this could be easily reversed)

JSteeleAZ commented 11 years ago

@Leonidaz : I was /just/ going to look into adding an autoClose to the excellent bPopup, but thought I should check the pull requests first, and lo-and-behold, there it is! Thanks for the update.

Leonidaz commented 11 years ago

it's really a very cool plugin, glad to contribute to it.

dinbror commented 11 years ago

Thanks for contributing. Please keep doing it.

In the next release I have added the transitions "slideUp" and "slideBack" and the transitionClose. I won't change delegate and bind to "on" yet due a lot of the users are still using versions of jquery below 1.7. Regarding the the autoClose feature I haven't thought on that. In what cases do you need such a feature

Leonidaz commented 11 years ago

@dinbror -- good thinking, agree. autoClose is really useful when the bPop is used as a notification popup (not in modal mode): user submits a form and you let them know that submission succeeded ("you have successfully added...."); or there were errors ("please correct ...." errors would also be shown in the form); or purely for notifications: "so and so tagged you in a photo", showing up at the top right or bottom right, etc.

dinbror commented 11 years ago

See version 0.9.4