search

dinbror / bpopup

bPopup is a lightweight jQuery modal popup plugin (only 1.34KB gzipped). It doesn't create or style your popup but provides you with all the logic like centering, modal overlay, events and more. It gives you a lot of opportunities to customize so it will fit your needs.
http://dinbror.dk/bPopup
427 stars 260 forks source link

beforeOpen and beforeClose #54

Open kouts opened 9 years ago

kouts commented 9 years ago

Hi, great plugin, can you consider implementing beforeOpen and beforeClose callbacks in addition to onOpen and onClose?

Thanks.

SnidelyWhiplash commented 9 years ago

+1, although I believe the current onOpen is fired before the modal is shown. So actually that should be renamed to onBeforeOpen and the current onOpen should be fired after the animations are complete. The current onClose does seem to fire after animation is complete so we'd just need an onBeforeClose.

SnidelyWhiplash commented 9 years ago

Oh, I just saw your fork and pull request, would be great to get that in. :)

cc: @dinbror

kouts commented 9 years ago

Thanks @SnidelyWhiplash , I have also implemented an autoOpen option but I'm not sure if if have done it right. I hope that gets in too.